Fix dbapi connection instrument wrapper has no _sock member #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srikanthccv @ocelotl May you both please take a look at this and let me know what you think? |
rogersd
force-pushed
the
drogers-dbapi-sock
branch
2 times, most recently
from
c9773b1 to
7f3d422
Compare
ocelotl
reviewed
Nov 3, 2022
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Outdated
Show resolved
Hide resolved
rogersd
force-pushed
the
drogers-dbapi-sock
branch
2 times, most recently
from
7e6e190 to
2b055d7
Compare
|
@lzchen Any chance you can get this in to |
rogersd
force-pushed
the
drogers-dbapi-sock
branch
from
2b055d7 to
bbf797b
Compare
srikanthccv
approved these changes
Nov 4, 2022
rogersd
force-pushed
the
drogers-dbapi-sock
branch
from
d319e45 to
88c6177
Compare
Fixes open-telemetry#1353 Also: Fix the check for the connection already being instrumented in instrument_connection() Add tests for commit() and rollback() Add a couple missing docstring items. Add basepython to docker-tests to fix running the tests on macOS.
rogersd
force-pushed
the
drogers-dbapi-sock
branch
from
88c6177 to
236f81e
Compare
ocelotl
approved these changes
Nov 7, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
…emetry#1424) Fixes open-telemetry#1353 Also: Fix the check for the connection already being instrumented in instrument_connection() Add tests for commit() and rollback() Add a couple missing docstring items. Add basepython to docker-tests to fix running the tests on macOS.
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
…emetry#1424) Fixes open-telemetry#1353 Also: Fix the check for the connection already being instrumented in instrument_connection() Add tests for commit() and rollback() Add a couple missing docstring items. Add basepython to docker-tests to fix running the tests on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the check for the connection already being instrumented in instrument_connection()
Add tests for commit() and rollback()
Add a couple missing docstring items.
Add basepython to docker-tests to fix running the tests on macOS.
Based on #1382
Fixes #1353
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.